Merge lp:~bloodearnest/canonical-identity-provider/talisker into lp:canonical-identity-provider/release
Status: | Rejected |
---|---|
Rejected by: | Simon Davy |
Proposed branch: | lp:~bloodearnest/canonical-identity-provider/talisker |
Merge into: | lp:canonical-identity-provider/release |
Diff against target: |
141 lines (+14/-50) 4 files modified
Makefile (+8/-2) django_project/settings_base.py (+1/-46) requirements.txt (+3/-2) src/testing/runner.py (+2/-0) |
To merge this branch: | bzr merge lp:~bloodearnest/canonical-identity-provider/talisker |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ricardo Kirkner (community) | Approve | ||
Review via email: mp+297455@code.launchpad.net |
Commit message
Add talisker, and remove explicit logging config, using the talisker logging configuration insteasd. Some dependencies now managed by talisker.
Description of the change
Add talisker, and remove explicit logging config. Some dependencies now managed by talisker.
The goal of talisker, in this instance
- standard logging format
- standard logging config (e.g. stderr)
- standardise some cross app common dependencies
The idea is to remove app-specific config for base log output, allowing easier control of logging across projects.
In terms of usage, there's some subtle changes to logging in development
Previously:
make run:
- gunicorn access and error logs to console
- sso/django logs to ./logs/sso.log
make test:
- sso/django logs to ./logs/sso.log
- all else to console (warnings, etc)
Now:
make run: all logs, including warnings, w/same format, to console. Nothing to disk
make test: null handler, no log output by default, but logging still works properly. Individual testcases can still use in-memory log handlers to capture log messages for assertion.
Comments welcome.
Unmerged revisions
- 1475. By Simon Davy
-
bump talisker to 0.4.1
- 1474. By Simon Davy
-
update to talisker 0.4.0
- 1473. By Simon Davy
-
merging, plus talisker tweak
- 1472. By Simon Davy
-
remove comment
- 1471. By Simon Davy
-
merge
- 1470. By Simon Davy
-
log to file for test runs
- 1469. By Simon Davy
-
merging
- 1468. By Simon Davy
-
add talisker
+1 to logging to console (one of the 12-factor app tenants) as it makes the application more portable (environment independence)