Code review comment for lp:~blamar/nova/openstack-api-1-1-images

Revision history for this message
Brian Lamar (blamar) wrote :

Hey Jay! Thanks for the comments:

> Please use zero or a single underscore, not two, for attributes.

Two leading underscores is Python's way of avoiding conflict with related sub/super class variables through 'name mangling'. I use this pretty regularly in my personal projects which is why it slipped in to this change. (http://docs.python.org/tutorial/classes.html#private-variables)

While I'll remove it if you/others think it doesn't belong, I technically think that any class member variable which isn't being used outside of the class it's defined should be 'Python private' to avoid conflicts...but maybe it's just a personal thing, are there any PEPs associated with the use of privates?

> This will break pep8 0.5.0.

We had a good discussion the other day about using specific versions in tools/pip-requires and I'd like to bring it up again since the last time you changed my mind about specifying specific versions.

Can I file a ticket to increase this version or are we linking it to the latest package release in Ubuntu? If any program we use should be the latest version, IMO it should be pep8.

« Back to merge proposal