Code review comment for lp:~blamar/nova/openstack-api-1-1-images

Revision history for this message
Brian Waldon (bcwaldon) wrote :

Many of your method-level comments refer to 'webob.Request'. This should actually be 'wsgi.Request'.

155: The _builder_dispatch dict can probably go away now. _get_builder takes care of it.

209: Looks like you called get_builder and build incorrectly: "return self.get_builder().build(req, image, True)" should be "return self.get_builder(req).build(image, True)"

review: Needs Fixing

« Back to merge proposal