Code review comment for lp:~blake-rouse/maas/vlan-relay
Revision history for this message
| Blake Rouse (blake-rouse) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
> Looks good; I have a few questions and comments below before this lands.
>
> Don't we also need a validation to ensure you cannot enable DHCP on a VLAN
> with a relay?
I did not want to block this. So if they enable DHCP it clears the relay_vlan and shows a warning in the UI when they go to enable.