Code review comment for lp:~blake-rouse/maas/node-effective-license-key

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Short and sweet. The explanation of what it means to get an "effective" licence key would go nicely in the docstring for get_effectivel_license_key.

Out of interest, why the calls to both LicenseKey.objects.has_license_key and LicenseKey.objects.get_license_key? Depending on the semantics, they sound a bit as if the combination is effectively one operation on LicenseKey.objects.

review: Approve

« Back to merge proposal