Code review comment for lp:~blake-rouse/maas/networks-edit-ui

Revision history for this message
Mike Pontillo (mpontillo) wrote :

This looks really good so far. Thanks for making this a directive; I think the code looks really clean.

I branched it and tested it out. Some obvious things need fixing, which I think you already know about for the most part, but I thought it might be helpful to make a list:

General comments:
(1) Labels appear to the right of edit widgets
(2) When pressing <enter> to save a field, it would be nice if it was consistent with the "clicking away" behavior (pressing enter should gray out the field to give the user an indication that saving is in progress, and they should no longer try to edit.)
(3) Pressing <esc> should cancel editing and revert the field to its previous value.
(4) Large text areas such as description fields should start out grayed out to be consistent with the smaller text fields; right now they always appear white.

Subnet page:
(5) We decided with the design team that the VLAN selection widget should not be a group by; rather it should change the acceptable VLANs based on the fabric selection. (I actually like it better as a group by, for the record, but I've got to pick my battles!) ;-)

VLAN page:
(6) Shouldn't the fabric be editable here? (only for the non-default VLAN...)

I think the only thing that blocks landing this branch is (1). (4) would be nice to have. The others could happen in follow-on branches.

review: Needs Fixing

« Back to merge proposal