Code review comment for lp:~blake-rouse/maas/import-with-gpg-home

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

test__import_resources_has_env_GNUPGHOME_set has this assertion:

        self.assertTrue(
            bootresources.MAAS_USER_GPGHOME,
            fake_download.env['GNUPGHOME'])

I think that assertTrue should have been assertEqual here.

One big question I'm left with is: who owns that home directory when you create it? It's still the maas user, right? It's important to get that right, but not the sort of thing you can really test.

review: Approve

« Back to merge proposal