Code review comment for lp:~blake-rouse/maas/fix-power8
Revision history for this message
| Blake Rouse (blake-rouse) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
Thanks for the review.
"slope towards spaghetti", totally agree! But this is one branch that could not be avoided, due to the current state of MAAS in the release process. Because of Django 1.8 and migrations we cannot release any new migrations in MAAS 1.9 and this branch has a requirement to be in MAAS 1.9. The only benefit we get out of this is we get to hide this stupid partition from the user. This is also fallout on not having every architecture in our CI. If this would have existed in our CI we would have caught this very early in the MAAS 1.9 cycle and I would not be doing it now and it could have been done properly and not as some magic if case throughout the storage generation.
See inline comments for responses. Also you reviewed an earlier version of the branch, some things have already changed.