Code review comment for lp:~blake-rouse/maas/fix-networking-add-ui

Revision history for this message
Mike Pontillo (mpontillo) wrote :

Looks much improved!

One issue I found: adding a VLAN fails and results in an error, 'Cannot assign "4": "VLAN.fabric" must be a "Fabric" instance.'

One suggestion: when you add a space, since it won't be associated with any fabrics it won't be visible in the default list. It would be nice to do something like $location.search('by', 'space'); so that the user can see the result of adding the space directly in the listing page after it happens.

« Back to merge proposal