Code review comment for lp:~blake-rouse/maas/fix-cache-clusters-images

Revision history for this message
Blake Rouse (blake-rouse) wrote :

> So much code for such a little thing! Still, at least it's bottled now.

Thats javascript! ;-)

> There are a few hundred lines of diff for something that, at first glance, appears unrelated, so
> Needs Information for that alone.

That addresses the bug linked to this branch. That bug shows that he was viewing a 1.9 UI with 2.0 javascript. The issue is that the partial views are being cached and the cache is not being broken with the ?v={version} on the file path.

In the process of fixing that bug I ran into an issue where the controllers listing was causing the regiond to crash. I fixed that, but by the time I was done trapnine landed image statuses on the details page as well. So I had to fix both, what was a very simple fix became large to do it correctly.

« Back to merge proposal