Code review comment for lp:~blake-rouse/maas/fix-bug-1324966

Revision history for this message
Julian Edwards (julian-edwards) wrote :

On 03/06/14 01:00, Raphaël Badin wrote:
> It's not always possible but we usually try to make the name of each test a bit more readable than this one it. This might seem a detail but it's really useful when reviewing tons of tests. In this instance I'd rename the test into "test_login_with_sshey". This is true for most of the tests in this branch.

I'd go a bit further with that. The test function names should
generally be of the format:

test_doing_foo_results_in_bar

IOW, test_login_with_sshkey should be
test_login_with_sshkey_attempts_connection, for example.

« Back to merge proposal