Merge lp:~blake-rouse/maas/fix-1522225 into lp:~maas-committers/maas/trunk

Proposed by Blake Rouse
Status: Merged
Approved by: Blake Rouse
Approved revision: no longer in the source branch.
Merged at revision: 4532
Proposed branch: lp:~blake-rouse/maas/fix-1522225
Merge into: lp:~maas-committers/maas/trunk
Diff against target: 54 lines (+8/-6)
1 file modified
src/maasserver/models/migrations/create_default_storage_layout.py (+8/-6)
To merge this branch: bzr merge lp:~blake-rouse/maas/fix-1522225
Reviewer Review Type Date Requested Status
Mike Pontillo (community) Approve
Review via email: mp+279383@code.launchpad.net

Commit message

Fix missing uuid on 181 migration.

To post a comment you must log in.
Revision history for this message
Mike Pontillo (mpontillo) wrote :

Re-tested by downloading the patch to /root/patch and executing:

cat /root/patch | patch -p1 -d /usr/lib/python2.7/dist-packages

Looks better now. Thanks for the fix.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/maasserver/models/migrations/create_default_storage_layout.py'
--- src/maasserver/models/migrations/create_default_storage_layout.py 2015-12-01 21:37:21 +0000
+++ src/maasserver/models/migrations/create_default_storage_layout.py 2015-12-03 01:59:48 +0000
@@ -31,6 +31,7 @@
31]31]
3232
33from datetime import datetime33from datetime import datetime
34from uuid import uuid4
3435
35from maasserver.enum import (36from maasserver.enum import (
36 FILESYSTEM_GROUP_TYPE,37 FILESYSTEM_GROUP_TYPE,
@@ -90,7 +91,7 @@
90 total_size += partition_size91 total_size += partition_size
91 root_partition = Partition.objects.create(92 root_partition = Partition.objects.create(
92 partition_table=partition_table, size=partition_size, bootable=True,93 partition_table=partition_table, size=partition_size, bootable=True,
93 created=now, updated=now)94 created=now, updated=now, uuid=uuid4())
9495
95 # Add the extra partitions if there is more space.96 # Add the extra partitions if there is more space.
96 partitions = [root_partition]97 partitions = [root_partition]
@@ -102,27 +103,28 @@
102 partitions.append(103 partitions.append(
103 Partition.objects.create(104 Partition.objects.create(
104 partition_table=partition_table, size=size, bootable=False,105 partition_table=partition_table, size=size, bootable=False,
105 created=now, updated=now))106 created=now, updated=now, uuid=uuid4()))
106 available_size -= size107 available_size -= size
107 total_size += size108 total_size += size
108109
109 # Create the volume group and logical volume.110 # Create the volume group and logical volume.
110 volume_group = FilesystemGroup.objects.create(111 volume_group = FilesystemGroup.objects.create(
111 name="vgroot", group_type=FILESYSTEM_GROUP_TYPE.LVM_VG,112 name="vgroot", group_type=FILESYSTEM_GROUP_TYPE.LVM_VG,
112 created=now, updated=now)113 created=now, updated=now, uuid=uuid4())
113 for partition in partitions:114 for partition in partitions:
114 Filesystem.objects.create(115 Filesystem.objects.create(
115 fstype=FILESYSTEM_TYPE.LVM_PV, partition=partition,116 fstype=FILESYSTEM_TYPE.LVM_PV, partition=partition, uuid=uuid4(),
116 filesystem_group=volume_group, created=now, updated=now)117 filesystem_group=volume_group, created=now, updated=now)
117 number_of_extents, _ = divmod(total_size, LVM_PE_SIZE)118 number_of_extents, _ = divmod(total_size, LVM_PE_SIZE)
118 lv_size = (number_of_extents - len(partitions)) * LVM_PE_SIZE119 lv_size = (number_of_extents - len(partitions)) * LVM_PE_SIZE
119 logical_volume = VirtualBlockDevice.objects.create(120 logical_volume = VirtualBlockDevice.objects.create(
120 node=node, name="lvroot", size=lv_size, block_size=4096,121 node=node, name="lvroot", size=lv_size, block_size=4096,
121 filesystem_group=volume_group, created=now, updated=now)122 filesystem_group=volume_group, created=now, updated=now, uuid=uuid4())
122 Filesystem.objects.create(123 Filesystem.objects.create(
123 block_device=logical_volume,124 block_device=logical_volume,
124 fstype=FILESYSTEM_TYPE.EXT4,125 fstype=FILESYSTEM_TYPE.EXT4,
125 label="root",126 label="root",
126 mount_point="/",127 mount_point="/",
127 created=now,128 created=now,
128 updated=now)129 updated=now,
130 uuid=uuid4())