Code review comment for lp:~blake-rouse/maas/fix-1509417

Digging through that log is annoying. But I found this:

maasserver.tests.test_forms_interface.BondInterfaceFormTest.test__creates_bond_interface_with_parent_mac_address ... ERROR
maasserver.tests.test_populate_tags.TestPopulateTags.test__calls_do_populate_tags_with_clusters ... FAIL

======================================================================
ERROR: maasserver.tests.test_forms_interface.BondInterfaceFormTest.test__creates_bond_interface_with_parent_mac_address
----------------------------------------------------------------------
_StringException: Traceback (most recent call last):
  File "/tmp/tarmac/branch.IXGl4c/src/maastesting/runtest.py", line 68, in _run_user
    result = function(*args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/testtools/testcase.py", line 616, in _run_test_method
    return self._get_test_method()()
  File "/tmp/tarmac/branch.IXGl4c/src/maasserver/tests/test_forms_interface.py", line 516, in test__creates_bond_interface_with_parent_mac_address
    vlan = factory.make_VLAN(vid=10)
  File "/tmp/tarmac/branch.IXGl4c/src/maasserver/testing/factory.py", line 739, in make_VLAN
    vlan.save()
  File "/tmp/tarmac/branch.IXGl4c/src/maasserver/models/cleansave.py", line 37, in save
    self.full_clean()
  File "/usr/lib/python2.7/dist-packages/django/db/models/base.py", line 950, in full_clean
    raise ValidationError(errors)
ValidationError: {'__all__': [u'VLAN with this Vid and Fabric already exists.']}

======================================================================
FAIL: maasserver.tests.test_populate_tags.TestPopulateTags.test__calls_do_populate_tags_with_clusters
----------------------------------------------------------------------
_StringException: Traceback (most recent call last):
  File "/tmp/tarmac/branch.IXGl4c/src/maastesting/runtest.py", line 68, in _run_user
    result = function(*args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/testtools/testcase.py", line 616, in _run_test_method
    return self._get_test_method()()
  File "/tmp/tarmac/branch.IXGl4c/src/maasserver/tests/test_populate_tags.py", line 244, in test__calls_do_populate_tags_with_clusters
    populate_tags_module.tag_nsmap))
  File "/usr/lib/python2.7/dist-packages/testtools/testcase.py", line 406, in assertThat
    raise mismatch_error
MismatchError: Expected call: mock(((u'd3892b66-7db1-11e5-a501-fa163e312456', u'cluster-kKQCvD', u'nSaYxW5vfF7Ch4hpS6:QyP7Kw8baU347hG7r8:2yWUpBW23SLrmhzta49NND73Rtks5ndm'), (u'd38bb390-7db1-11e5-a501-fa163e312456', u'cluster-GMo8FL', u'N76yENgGPFVjbzXhSE:H3MNtwh824fB9ezxj6:N4XHy6nELjjNC26yZEvBMjdc3RmqeXJu'), (u'd38d73f6-7db1-11e5-a501-fa163e312456', u'cluster-bgk6Vv', u'dReXSBYBrD82JkcCpv:wApPKrTsbp3rsBLAfj:Eu77CdEkfYg8SJ4NZeGWzuk8EUdS8hQR')), u'tag-6TAjrG', u'//node', {u'lldp': u'lldp', u'lshw': u'lshw'})
Actual call: mock(((u'd38d73f6-7db1-11e5-a501-fa163e312456', u'cluster-bgk6Vv', u'dReXSBYBrD82JkcCpv:wApPKrTsbp3rsBLAfj:Eu77CdEkfYg8SJ4NZeGWzuk8EUdS8hQR'), (u'd3892b66-7db1-11e5-a501-fa163e312456', u'cluster-kKQCvD', u'nSaYxW5vfF7Ch4hpS6:QyP7Kw8baU347hG7r8:2yWUpBW23SLrmhzta49NND73Rtks5ndm'), (u'd38bb390-7db1-11e5-a501-fa163e312456', u'cluster-GMo8FL', u'N76yENgGPFVjbzXhSE:H3MNtwh824fB9ezxj6:N4XHy6nELjjNC26yZEvBMjdc3RmqeXJu')), u'tag-6TAjrG', u'//node', {u'lldp': u'lldp', u'lshw': u'lshw'})

Looks unrelated.

Random duplicate VID? Not sure what the other one is.