Code review comment for lp:~blake-rouse/maas/fix-1443959

Revision history for this message
Mike Pontillo (mpontillo) wrote :

Looks generally good. I have a minor comment below about some code that looks to bit a bit boilerplate. I think we might be able to do better with some slight refactoring; right now it seems like we have objects and constants scattered about for the nodes and devices; maybe if a single object knew about all these, it would be cleaner?

review: Approve

« Back to merge proposal