Code review comment for lp:~blake-rouse/maas/error-overlay-directive
Revision history for this message
| Blake Rouse (blake-rouse) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
f33e652
(Get the code!)
I will update it to "Connecting...", but I think he was talking more specifically about the detailed error message as well.
Yes the entire page changes to that. This is the way design implemented it, I wanted to just do a modal overlay, but they said this works better. Anyway its not that fast, if the connection goes down it will take a moment for it to reconnect. If the connection goes down and back up quickly you will not see the error. I will update the directive to only show if disconnected for more than 1 second.
I will generalize the errors displayed and just log the detailed errors to the browser console.