As Jason pointed out, it's always best to land tests with the code they test. For new models, a basic test is enough. You also might want to add a make_<my_model> utility in the test factory (src/maasserver/testing/factory.py)
[1]
See my inline comment about using null=True on Charfields.
[2]
As Jason pointed out, don't forget to run:
$ ./utilities/format-new-and-modified-imports
and
$ make lint
before you submit a branch.
[0]
As Jason pointed out, it's always best to land tests with the code they test. For new models, a basic test is enough. You also might want to add a make_<my_model> utility in the test factory (src/maasserver /testing/ factory. py)
[1]
See my inline comment about using null=True on Charfields.
[2]
As Jason pointed out, don't forget to run: format- new-and- modified- imports
$ ./utilities/
and
$ make lint
before you submit a branch.
[3]
Please update the Node's docstring.