Code review comment for lp:~blake-rouse/maas/add-boot-type-to-node

Revision history for this message
Raphaƫl Badin (rvb) wrote :

Looks good. I've got a couple of comment (see inline) but more importantly:

Now that boot_type is a property on the node, we don't really need the should_use_fastpath_installer/should_use_traditional_installer encapsulations anymore.

Actually, if you exclude the tests, should_use_fastpath_installer is used only once and should_use_traditional_installer is not even used anymore (!).

review: Approve

« Back to merge proposal