Merge ~blake-rouse/maas:fix-1793340-part2 into maas:master

Proposed by Blake Rouse
Status: Merged
Approved by: Blake Rouse
Approved revision: 2abba6dd80bf13796e4dc8bb8d3d5072960cd2bc
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~blake-rouse/maas:fix-1793340-part2
Merge into: maas:master
Diff against target: 77 lines (+47/-2)
3 files modified
src/maasserver/migrations/builtin/maasserver/0177_remove_unique_together_on_bmc.py (+45/-0)
src/maasserver/migrations/builtin/maasserver/0178_break_apart_linked_bmcs.py (+1/-1)
src/provisioningserver/drivers/power/wedge.py (+1/-1)
Reviewer Review Type Date Requested Status
Newell Jensen (community) Approve
Andres Rodriguez (community) Approve
Review via email: mp+355611@code.launchpad.net

Commit message

Fix issues where unique_together in the Django model (not postgresql) was preventing the new BMC migration to run.

To post a comment you must log in.
Revision history for this message
Andres Rodriguez (andreserl) wrote :

lgtm!

review: Approve
Revision history for this message
Newell Jensen (newell-jensen) wrote :

+1

review: Approve
Revision history for this message
MAAS Lander (maas-lander) wrote :
~blake-rouse/maas:fix-1793340-part2 updated
6b45ca5... by Blake Rouse

Wedge power driver is not a chassis.

ff7b399... by Blake Rouse

Merge branch 'master' into fix-1793340-part2

2abba6d... by Blake Rouse

Fix issue with merge.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/maasserver/migrations/builtin/maasserver/0177_remove_unique_together_on_bmc.py b/src/maasserver/migrations/builtin/maasserver/0177_remove_unique_together_on_bmc.py
2new file mode 100644
3index 0000000..7272a17
4--- /dev/null
5+++ b/src/maasserver/migrations/builtin/maasserver/0177_remove_unique_together_on_bmc.py
6@@ -0,0 +1,45 @@
7+# -*- coding: utf-8 -*-
8+# Generated by Django 1.11.11 on 2018-09-25 17:03
9+from __future__ import unicode_literals
10+
11+from django.db import migrations
12+
13+
14+class AlterUniqueTogetherNoDB(migrations.AlterUniqueTogether):
15+ """A `AlterUniqueTogether` that doesn't actually touch the DB it only
16+ updates the model schema.
17+
18+ Because of migrations:
19+
20+ - 0163_create_new_power_parameters_with_jsonfield
21+ - 0164_copy_over_existing_power_parameters
22+ - 0165_remove_and_rename_power_parameters
23+
24+ The unique_together was removed by PostgreSQL automatically, so performing
25+ DB changes actually results in an error because it has already been
26+ removed.
27+ """
28+
29+ def database_forwards(
30+ self, app_label, schema_editor, from_state, to_state):
31+ # Do nothing.
32+ pass
33+
34+ def database_backwards(
35+ self, app_label, schema_editor, from_state, to_state):
36+ # Do nothing.
37+ pass
38+
39+
40+class Migration(migrations.Migration):
41+
42+ dependencies = [
43+ ('maasserver', '0176_rename_user_id_migrate_to_user_id_for_events'),
44+ ]
45+
46+ operations = [
47+ AlterUniqueTogetherNoDB(
48+ name='bmc',
49+ unique_together=set([]),
50+ ),
51+ ]
52diff --git a/src/maasserver/migrations/builtin/maasserver/0177_break_apart_linked_bmcs.py b/src/maasserver/migrations/builtin/maasserver/0178_break_apart_linked_bmcs.py
53index 13c26a9..19bdca0 100644
54--- a/src/maasserver/migrations/builtin/maasserver/0177_break_apart_linked_bmcs.py
55+++ b/src/maasserver/migrations/builtin/maasserver/0178_break_apart_linked_bmcs.py
56@@ -34,7 +34,7 @@ def break_apart_linked_bmcs(apps, schema_editor):
57 class Migration(migrations.Migration):
58
59 dependencies = [
60- ('maasserver', '0176_rename_user_id_migrate_to_user_id_for_events'),
61+ ('maasserver', '0177_remove_unique_together_on_bmc'),
62 ]
63
64 operations = [
65diff --git a/src/provisioningserver/drivers/power/wedge.py b/src/provisioningserver/drivers/power/wedge.py
66index 61f89ff..9b3ca1c 100644
67--- a/src/provisioningserver/drivers/power/wedge.py
68+++ b/src/provisioningserver/drivers/power/wedge.py
69@@ -32,7 +32,7 @@ class WedgeState:
70 class WedgePowerDriver(PowerDriver):
71
72 name = 'wedge'
73- chassis = True
74+ chassis = False
75 description = "Facebook's Wedge"
76 settings = [
77 make_setting_field('power_address', "IP address", required=True),

Subscribers

People subscribed via source and target branches