Merge ~blake-rouse/maas:fix-1699864 into maas:master
Proposed by
Blake Rouse
Status: | Merged |
---|---|
Approved by: | Blake Rouse |
Approved revision: | d2ccf801825b46ff0c571c1631662d50005c4526 |
Merge reported by: | MAAS Lander |
Merged at revision: | not available |
Proposed branch: | ~blake-rouse/maas:fix-1699864 |
Merge into: | maas:master |
Diff against target: |
236 lines (+34/-33) 3 files modified
src/maasserver/static/js/angular/directives/machines_table.js (+14/-14) src/maasserver/static/js/angular/directives/tests/test_machines_table.js (+19/-18) src/maasserver/static/partials/machines-table.html (+1/-1) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Andres Rodriguez (community) | Approve | ||
Review via email: mp+326936@code.launchpad.net |
Commit message
Fix machinesTable directive so that it works with vs-repeat.
The machines, filteredMachines, and osinfo where placed on the scope directly. Once vs-repeat was added it changed the scope inside the directive to be the scope of vs-repeat and not the scope of machines-table. Moving those variables to the table variable on the machines-table scope fixes the issue as the table object will be copied by reference into the nested vs-repeat scope.
To post a comment you must log in.
lgtm!