Merge ~bladernr/plainbox-provider-checkbox:1922246-fix-validation-warnings into plainbox-provider-checkbox:master

[Jeff Lane ]

Fix a bunch of validation warnings in P-P-C that are just a bunch of noise when trying to check updates to the provider.

[Sylvain Pineau (sylvain-pineau)]

+1, thx a lot

review: Approve

diff --git a/units/audio/manifest.pxu b/units/audio/manifest.pxu
index d3e285b..73ad218 100644
--- a/units/audio/manifest.pxu
+++ b/units/audio/manifest.pxu
@@ -16,6 +16,6 @@ value-type: bool
 
 unit: manifest entry
 id: has_audio_loopback_connector
-prompt: Does this device have the following?:
+_prompt: Does this device have the following?:
 _name: Audio Loopback Connector
 value-type: bool
diff --git a/units/firmware/jobs.pxu b/units/firmware/jobs.pxu
index b0d69cb..74d13ef 100644
--- a/units/firmware/jobs.pxu
+++ b/units/firmware/jobs.pxu
@@ -91,8 +91,8 @@ _summary: Attach FWTS Server Cert test log to submission
 
 id: firmware/tcglog-required-algs-sha256
 category_id: com.canonical.plainbox::firmware
-summary: Test that the SHA256 algorithm is present in the TCG event log
-description:
+_summary: Test that the SHA256 algorithm is present in the TCG event log
+_description:
   Presence of support for the SHA256 algorithm is a requirement for enabling FDE
   support in Ubuntu Core 20 systems
 plugin: shell
@@ -106,8 +106,8 @@ requires:
 
 id: firmware/tcglog-require-pe-image-digests
 category_id: com.canonical.plainbox::firmware
-summary: Test format of digests for EV_EFI_BOOT_SERVICES_APPLICATION events
-description:
+_summary: Test format of digests for EV_EFI_BOOT_SERVICES_APPLICATION events
+_description:
   Digests for EV_EFI_BOOT_SERVICES_APPLICATION events associated with PE images
   must be PE image digests rather than file digests. This test is a requirement
   for enabling FDE support in Ubuntu Core 20 systems
@@ -122,7 +122,7 @@ requires:
 
 id: firmware/tcglog-dump-attachment
 category_id: com.canonical.plainbox::firmware
-summary: Attach a dump of the TCG Event log for debugging
+_summary: Attach a dump of the TCG Event log for debugging
 plugin: attachment
 user: root
 command: tcglog-dump
diff --git a/units/gpio/manifest.pxu b/units/gpio/manifest.pxu
index d7174ca..e48680b 100644
--- a/units/gpio/manifest.pxu
+++ b/units/gpio/manifest.pxu
@@ -1,5 +1,5 @@
 unit: manifest entry
 id: gpio_loopback
-prompt: Does this device have the following?:
+_prompt: Does this device have the following?:
 _name: GPIO Loopback Connector
-value-type: bool
 \ No newline at end of file
+value-type: bool
diff --git a/units/image/jobs.pxu b/units/image/jobs.pxu
index 2cbbff5..d185550 100644
--- a/units/image/jobs.pxu
+++ b/units/image/jobs.pxu
@@ -1,8 +1,8 @@
 
 id: image/kernel-publisher-canonical
 category_id: image
-summary: Check that the kernel snap publisher is Canonical
-description:
+_summary: Check that the kernel snap publisher is Canonical
+_description:
   During certification testing IoT devices must be running a kernel supplied
   by Canonical
 plugin: shell
@@ -13,8 +13,8 @@ flags: preserve-locale
 
 id: image/kernel-tracking-stable
 category_id: image
-summary: Check that the kernel snap is tracking stable channel
-description:
+_summary: Check that the kernel snap is tracking stable channel
+_description:
   During certification testing IoT devices must be running a kernel that is on
   a stable channel
 plugin: shell
@@ -25,8 +25,8 @@ flags: preserve-locale
 
 id: image/gadget-publisher-canonical
 category_id: image
-summary: Check that the gadget snap publisher is Canonical
-description:
+_summary: Check that the gadget snap publisher is Canonical
+_description:
   During certification testing IoT devices must be running a kernel supplied
   by Canonical
 plugin: shell
@@ -37,8 +37,8 @@ flags: preserve-locale
 
 id: image/gadget-tracking-stable
 category_id: image
-summary: Check that the gadget snap is tracking stable channel
-description:
+_summary: Check that the gadget snap is tracking stable channel
+_description:
   During certification testing IoT devices must be running a gadget that is on
   a stable channel
 plugin: shell
@@ -49,8 +49,8 @@ flags: preserve-locale
 
 id: image/model-authority-canonical
 category_id: image
-summary: Check that model authority-id is canonical
-description:
+_summary: Check that model authority-id is canonical
+_description:
   The authority-id declares on whose authority this assertion is made. This
   must be Canonical for the certification of IoT devices.
 plugin: shell
@@ -61,8 +61,8 @@ flags: preserve-locale
 
 id: image/model-brand-canonical
 category_id: image
-summary: Check the model brand-id is canoncial
-description:
+_summary: Check the model brand-id is canoncial
+_description:
   For the certification of IoT devices canonical provided generic images must
   be used. Hence, the brand-id must be canonical.
 plugin: shell
@@ -73,10 +73,10 @@ flags: preserve-locale
 
 id: image/model-grade-not-dangerous
 category_id: image
-summary: Check that the model grade is not missing or set to dangerous
+_summary: Check that the model grade is not missing or set to dangerous
 requires:
  lsb.distributor_id == "Ubuntu Core" and int(lsb.release) >= 20
-description:
+_description:
   Images with the 'dangerous' grade (the lowest of all available grades)
   results in certain security measures to be relaxed.
   Images that require strict security related implementations must
diff --git a/units/image/test-plan.pxu b/units/image/test-plan.pxu
index 48af204..73e5fa3 100644
--- a/units/image/test-plan.pxu
+++ b/units/image/test-plan.pxu
@@ -1,7 +1,7 @@
 
 id: iot-cert-image-full
 unit: test plan
-name: Sanity checks for images being certified on IoT devices
+_name: Sanity checks for images being certified on IoT devices
 include:
 nested_part:
     iot-cert-image-manual
@@ -9,12 +9,12 @@ nested_part:
 
 id: iot-cert-image-automated
 unit: test plan
-name: Automated Sanity checks for images being certified on IoT devices
+_name: Automated Sanity checks for images being certified on IoT devices
 include:
   image/.*
 
 id: iot-cert-image-manual
 unit: test plan
-name: Manual Sanity checks for images being certified on IoT devices
+_name: Manual Sanity checks for images being certified on IoT devices
 include:
 
diff --git a/units/keys/jobs.pxu b/units/keys/jobs.pxu
index 3b42f3e..423b2f3 100644
--- a/units/keys/jobs.pxu
+++ b/units/keys/jobs.pxu
@@ -306,10 +306,10 @@ command:
   gsettings set org.gnome.settings-daemon.plugins.power power-button-action "$action"
   [[ $(grep -c "PBTN.*00000080" "$PLAINBOX_SESSION_SHARE"/power-button-event.log) -eq 1 ]] || \
   [[ $(grep -c "PWRB.*00000080" "$PLAINBOX_SESSION_SHARE"/power-button-event.log) -eq 1 ]]
-purpose:
+_purpose:
   This test will check if power button event has reported correctly, the listener will
   wait for 10 seconds.
-steps:
+_steps:
   1. Single press and release the power button in 10 seconds, some platforms might need long-press
      to trigger the PBTN or PWRB event
   2. Check the number of output PBTN/PWRB event
diff --git a/units/socketcan/manifest.pxu b/units/socketcan/manifest.pxu
index 2c9b898..d2efeb5 100644
--- a/units/socketcan/manifest.pxu
+++ b/units/socketcan/manifest.pxu
@@ -1,6 +1,6 @@
 
 unit: manifest entry
 id: socket_can_echo_server_running
-prompt: Is the device connected to the following?:
+_prompt: Is the device connected to the following?:
 _name: A SocketCAN Echo Server
 value-type: bool