Merge ~bladernr/plainbox-provider-checkbox:1801963-server-fwts-jobs into plainbox-provider-checkbox:master

Proposed by Jeff Lane 
Status: Merged
Approved by: Jeff Lane 
Approved revision: ec9d092738691513a4217d352537add4013e4256
Merged at revision: b2cdb6a6ef56c709014f68f94d6c3eb8bd537ccc
Proposed branch: ~bladernr/plainbox-provider-checkbox:1801963-server-fwts-jobs
Merge into: plainbox-provider-checkbox:master
Diff against target: 47 lines (+33/-0)
2 files modified
units/firmware/jobs.pxu (+22/-0)
units/firmware/test-plan.pxu (+11/-0)
Reviewer Review Type Date Requested Status
Maciej Kisielewski (community) Approve
Review via email: mp+358408@code.launchpad.net

Description of the change

Adds jobs to run selected fwts tests for server cert.
Adds a new test plan to units/firmware to provide nested test-plans

To post a comment you must log in.
Revision history for this message
Maciej Kisielewski (kissiel) wrote :

Looks clean! +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/units/firmware/jobs.pxu b/units/firmware/jobs.pxu
index 5c8dcee..4dae484 100644
--- a/units/firmware/jobs.pxu
+++ b/units/firmware/jobs.pxu
@@ -74,3 +74,25 @@ user: root
74estimated_duration: 0.574estimated_duration: 0.5
75command: ! sudo grep -r "_REV" /sys/firmware/acpi/tables/* | grep [DS]SDT75command: ! sudo grep -r "_REV" /sys/firmware/acpi/tables/* | grep [DS]SDT
76_description: This Automated test checks misuse of the _REV interface in ACPI DSDT and SSDT tables76_description: This Automated test checks misuse of the _REV interface in ACPI DSDT and SSDT tables
77
78plugin:shell
79category_id: com.canonical.plainbox::firmware
80id: firmware/fwts_server
81estimated_duration: 10.0
82requires: executable.name == 'fwts'
83user: root
84_description:
85 Run Firmware Test Suite (fwts) Server Cert selected tests.
86_summary: Run FWTS Server Cert selected tests.
87environ: PLAINBOX_SESSION_SHARE
88command:
89 checkbox-support-fwts_test --server -q -l $PLAINBOX_SESSION_SHARE/fwts_server_results.log
90
91plugin: attachment
92category_id: com.canonical.plainbox::firmware
93estimated_duration: 0.5
94id: firmware/fwts_server_results.log.gz
95command:
96 [ -f $PLAINBOX_SESSION_SHARE/fwts_server_results.log ] && gzip -c $PLAINBOX_SESSION_SHARE/fwts_server_results.log
97_description: Attaches the FWTS Server Cert results log to the submission
98_summary: Attach FWTS Server Cert test log to submission
diff --git a/units/firmware/test-plan.pxu b/units/firmware/test-plan.pxu
77new file mode 10064499new file mode 100644
index 0000000..62b4e05
--- /dev/null
+++ b/units/firmware/test-plan.pxu
@@ -0,0 +1,11 @@
1id: server-firmware
2unit: test plan
3_name: Server Firmware Tests
4_description:
5 Server Focused Firmware Tests
6mandatory_include:
7 firmware/fwts_server
8 firmware/fwts_results.log.gz
9include:
10bootstrap_include:
11 fwts

Subscribers

People subscribed via source and target branches