Code review comment for ~bladernr/plainbox-provider-checkbox:1628264-virt-timeout

Revision history for this message
Rod Smith (rodsmith) wrote :

OK. I see you've fixed the couple of pep8 complaints. (I agree that these Python code-checking tools are overly-anal, but I wanted you to be aware of the fact that they ARE complaining a lot when fed this script.) Your explanation for why duplicating code in the "while" loop's "else" clause is necessary makes sense. Thus, I'm accepting this version.

review: Approve

« Back to merge proposal