Merge ~bladernr/plainbox-provider-checkbox:1686746-network-info-show-speed into plainbox-provider-checkbox:master

Proposed by Jeff Lane 
Status: Merged
Approved by: Sylvain Pineau
Approved revision: c71173a9f525146301c8f3bc84df55652df0dc41
Merged at revision: fe98bbdd934426fd665557ea553952faa90ca20a
Proposed branch: ~bladernr/plainbox-provider-checkbox:1686746-network-info-show-speed
Merge into: plainbox-provider-checkbox:master
Diff against target: 36 lines (+13/-1)
1 file modified
bin/network_info (+13/-1)
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Approve
Review via email: mp+323331@code.launchpad.net

Description of the change

Adds the contents of /sys/net/DEV/speed to the output of network_info script.

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

Useful indeed, +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/bin/network_info b/bin/network_info
index 9c20b89..38d5ada 100755
--- a/bin/network_info
+++ b/bin/network_info
@@ -51,12 +51,23 @@ def get_mac_address(interface):
5151
52 address = ''52 address = ''
53 try:53 try:
54 address = _read_file(address_file)54 address = _read_file(address_file).strip()
55 except IOError:55 except IOError:
56 pass56 pass
5757
58 return address58 return address
5959
60def get_speed(interface):
61 speed_file = os.path.join(SYS_PATH, interface, 'speed')
62
63 speed = ''
64 try:
65 speed = _read_file(speed_file).strip()
66 except IOError:
67 pass
68
69 return speed
70
6071
61def main(args):72def main(args):
62 for interface in args:73 for interface in args:
@@ -74,6 +85,7 @@ def main(args):
74 except:85 except:
75 print("IPv6: n/a")86 print("IPv6: n/a")
76 print("MAC: %s\n" % get_mac_address(interface))87 print("MAC: %s\n" % get_mac_address(interface))
88 print("Connect Speed: %s" % get_speed(interface))
7789
78 return 090 return 0
7991

Subscribers

People subscribed via source and target branches