Code review comment for lp:~bladernr/opencompute/ocp-cleanup

Revision history for this message
Jeff Lane  (bladernr) wrote :

Oh... snap. Good points, I didn't think that there would be actual
scripts in the POTILEs list...

Nor did I think about unit tests for them... good call.

On Sat, Aug 17, 2013 at 3:28 PM, Jeff Marcom <email address hidden> wrote:
> Review: Needs Fixing
>
> Some of the files removed from the scripts directory seem to be still in po/POTFILES.in,
>
> like this one:
> scripts/keyboard_test
>
>
> Also, please make sure that whatever jobs are removed here, the corresponding unittest for them are removed as well.
>
> Sorry :/
> --
> https://code.launchpad.net/~bladernr/opencompute/ocp-cleanup/+merge/179783
> You are the owner of lp:~bladernr/opencompute/ocp-cleanup.

--
Jeff Lane - Server and Cloud Certification and Tools Development
Ubuntu Ham: W4KDH
Freenode IRC: bladernr or bladernr_
gpg: 1024D/3A14B2DD 8C88 B076 0DD7 B404 1417 C466 4ABD 3635 3A14 B2DD

« Back to merge proposal