~bladernr/maas:2042821-apt-key-deprecation

Branch merges

Propose for merging

Ready for review for merging into maas:master

Alexsander de Souza: Needs Fixing on 2023-11-14

MAAS Lander: Needs Fixing on 2023-11-07

Diff: 24 lines (+2/-4)

1 file modified

package-files/etc/maas/preseeds/curtin_userdata (+2/-4)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

56136ca... by Jeff Lane  on 2023-11-07

removed deprecated calls to apt-key and replaced them with a suggested alternative method. This is based on work Rod Smith did to fix this in our own modified curtin_userdata file in maas-cert-server. fixes: lp:2042821

3dd97d8... by Alberto Donato on 2023-11-06

add boolean type for script parameters

f06ea63... by Mauricio Faria de Oliveira on 2023-11-06

LP:2040188 - bmc-config: add missing script metadata for parameter maas_auto_ipmi_cipher_suite_id

The bmc-config script is passed several parameters from MAAS config options
(e.g. maas_auto_ipmi_{user,user_password,user_privilege_level,k_g_bmc_key}).

But maas_auto_ipmi_cipher_suite_id is not, since it's not in the metadata.

Add it to actually allow users to change the default IPMI cipher suite ID.

Tested on MAAS 3.4.0~rc2 with this debug change to print script arguments:

         def main():
         ...
             args = parser.parse_args()
        + print(args)
         ...

Change MAAS config for IPMI cipher suite ID from 3 to 17:

        $ maas admin maas get-config \
          name=maas_auto_ipmi_cipher_suite_id
        Success.
        Machine-readable output follows:
        "3"

        $ maas admin maas set-config \
          name=maas_auto_ipmi_cipher_suite_id \
          value=17
        Success.
        Machine-readable output follows:
        OK

        $ maas admin maas get-config \
          name=maas_auto_ipmi_cipher_suite_id
        Success.
        Machine-readable output follows:
        "17"

Before:
(17 is not used; source code default of 3 is used, instead)

        Namespace(ipmi_cipher_suite_id='3', ipmi_k_g='', ipmi_privilege_level='ADMIN', password=None, username='maas')

After:
(17 is now used!)

        Namespace(ipmi_cipher_suite_id='17', ipmi_k_g='', ipmi_privilege_level='ADMIN', password=None, username='maas')

Found by comparison with (working) parameter maas_auto_ipmi_user:

        $ grep -r 'maas_auto_ipmi_user[^_]' | grep -vw -e maasui -e maas-offline-docs -e tests
        src/metadataserver/builtin_scripts/commissioning_scripts/bmc_config.py:# maas_auto_ipmi_user:
        src/maasserver/forms/settings.py: "maas_auto_ipmi_user": {
        src/maasserver/forms/parameters.py: "maas_auto_ipmi_user",
        src/maasserver/models/config.py: "maas_auto_ipmi_user": "maas",

        $ grep -r 'maas_auto_ipmi_cipher_suite_id[^_]' | grep -vw -e maasui -e maas-offline-docs -e tests
        src/maasserver/forms/settings.py: "maas_auto_ipmi_cipher_suite_id": {
        src/maasserver/forms/parameters.py: "maas_auto_ipmi_cipher_suite_id",
        src/maasserver/models/config.py: "maas_auto_ipmi_cipher_suite_id": "3",

Signed-off-by: Mauricio Faria de Oliveira <email address hidden>

e193989... by Anton Troyanov on 2023-11-03

refactor: do not fail the whole power-many wf

If one machine has incorrect power action, we should not fail.
We don't want to have state when the first half succeeded and the remainder failed.

29036e7... by Christian Grabowski on 2023-11-03

feat: add images proxy

4933ac7... by Alexsander de Souza on 2023-11-03

optimize bootresources download

- group files by hash
- smooth the progress report (don't hammer the `images-sync-progress` API endpoint)

490d4e9... by Anton Troyanov on 2023-11-03

refactor: power workflow cleanup

- Rename PowerNWorkflow to PowerManyWorkflow
During conversations we call it PowerMany, because PowerN doesn't soundwell.

- Rename Queue property to TaskQueue.
We should use Temporal terms for Temporal related code (workflows/activities). The correct term in this case is Task Queue, as queue might be something different.

- Remove custom ID for the PowerMany workflow
If we need uniqueness, then we can leave it blank and a random GUID will be generated

7c0e8c2... by Anton Troyanov on 2023-11-02

fix: ScheduleToCloseTimeout for checkIP activity

We don't want Activities to be retried forever.

> ScheduleToCloseTimeout - The end to end timeout for the local activity including retries.
> This field is required.

b3dae13... by Christian Grabowski on 2023-11-02

always use the DomainInfo network for reverse zones and check IP belongs to it

b1a65c3... by Bill Wear on 2023-11-02

Update maas-offline-docs to b0998d49
revert this page to tabbed version, tabs needed here for 5436