Code review comment for lp:~bladernr/checkbox/network-fail-value-opton

Revision history for this message
Daniel Manrique (roadmr) wrote :

Jeff is aware of a couple of needed fixes, just marking this as needs fixing to avoid review duplication, details:

11:56 < roadmr> bladernr: :( changelog conflict :(
11:57 < roadmr> bladernr: would you be opposed to changing fail_speed to
                fail_threshold? fail_speed suggests, well, a speed value, so
                it's a bit confusing (what are the units? why is the default 40
                of those units? and so on)

review: Needs Fixing

« Back to merge proposal