Merge lp:~bladernr/checkbox/iperf3-dependency into lp:~checkbox-dev/checkbox/ppa-packaging-plainbox-provider-canonical-certification

Proposed by Jeff Lane 
Status: Rejected
Rejected by: Sylvain Pineau
Proposed branch: lp:~bladernr/checkbox/iperf3-dependency
Merge into: lp:~checkbox-dev/checkbox/ppa-packaging-plainbox-provider-canonical-certification
Diff against target: 11 lines (+1/-0)
1 file modified
debian/control (+1/-0)
To merge this branch: bzr merge lp:~bladernr/checkbox/iperf3-dependency
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Disapprove
Review via email: mp+279656@code.launchpad.net

Description of the change

Add iperf3 as a package suggestion for server provider package

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

The certification providers are in a got repo now; I've already proposed to add iperf3 as a recommended package:

https://git.launchpad.net/~checkbox-dev/plainbox-provider-canonical-certification/+git/packaging-server/commit/?id=5e4a65ea4480f9709ed66122b453a2234dfed8bc

The bzr branches are no longer used to build cert providers.

review: Disapprove
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

s/got/git

Revision history for this message
Jeff Lane  (bladernr) wrote :

That's cool. I know that they're in a git repo, but when I pulled the
latest from the git repo, there was no packaging data. Where is that
hiding? Am I just blind?

On Monday, December 7, 2015, Sylvain Pineau <email address hidden>
wrote:

> The proposal to merge lp:~bladernr/checkbox/iperf3-dependency into
> lp:~checkbox-dev/checkbox/ppa-packaging-plainbox-provider-canonical-certification
> has been updated.
>
> Status: Needs review => Rejected
>
> For more details, see:
>
> https://code.launchpad.net/~bladernr/checkbox/iperf3-dependency/+merge/279656
> --
> You are the owner of lp:~bladernr/checkbox/iperf3-dependency.
>
> Launchpad-Message-Rationale: Owner
> Launchpad-Message-For: bladernr
> Launchpad-Notification-Type: code-review
> Launchpad-Branch: ~bladernr/checkbox/iperf3-dependency
> Launchpad-Project: checkbox
>

--
Sent from my iPhone so please forgive any typos, top posting and such.

Unmerged revisions

55. By Jeff Lane 

added iperf3 as a package suggestion for ppcs

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2015-08-06 19:28:16 +0000
3+++ debian/control 2015-12-04 20:49:24 +0000
4@@ -77,6 +77,7 @@
5 dnsutils,
6 fwts (>=13.09.00-0ubuntu1),
7 iperf,
8+ iperf3,
9 ipmitool,
10 libapache2-mod-php5,
11 mysql-server,

Subscribers

People subscribed via source and target branches