Merge lp:~bladernr/checkbox/fix-wireless-suspend-tests into lp:checkbox
Proposed by
Jeff Lane
Status: | Merged |
---|---|
Merged at revision: | 1063 |
Proposed branch: | lp:~bladernr/checkbox/fix-wireless-suspend-tests |
Merge into: | lp:checkbox |
Diff against target: |
37 lines (+5/-3) 2 files modified
debian/changelog (+3/-1) jobs/suspend.txt.in (+2/-2) |
To merge this branch: | bzr merge lp:~bladernr/checkbox/fix-wireless-suspend-tests |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Daniel Manrique (community) | Approve | ||
Review via email: mp+76612@code.launchpad.net |
Description of the change
instead of just pushing this to trunk, looking for a review to sanity check removing the bits from wireless_
That seemed unnecessary if the goal of the iface file is just to ensure we restart the interface that was in use when wireless_
I tested this on a thinkpad x201 and had no issues with it changed like this.
To post a comment you must log in.
I tested the commands individually and they seem sane, I also agree that the *after* test doesn't need to write to the iface file, just restore as per what was written there.
And of course, clobbering the file with > instead of appending >> makes a lot of sense, though that would only surface if repeated runs are made without clearing the .checkbox directory; of course, that's an arcane trick so anything that spares end users from pain is welcome.
This looks good so I'll be merging it. Thanks!