Merge lp:~bladernr/checkbox/990538 into lp:checkbox

Proposed by Jeff Lane 
Status: Merged
Merged at revision: 1681
Proposed branch: lp:~bladernr/checkbox/990538
Merge into: lp:checkbox
Diff against target: 48 lines (+12/-2) (has conflicts)
2 files modified
debian/changelog (+6/-0)
jobs/keys.txt.in (+6/-2)
Text conflict in debian/changelog
To merge this branch: bzr merge lp:~bladernr/checkbox/990538
Reviewer Review Type Date Requested Status
Marc Tardif (community) Approve
Review via email: mp+125272@code.launchpad.net

Description of the change

changed keys/battery_info so that it now uses the keys_test script. Unfortunately, it still opens the Power Statistics tool, but the verification is automatic using the script.

To post a comment you must log in.
Revision history for this message
Marc Tardif (cr3) wrote :

I took the liberty of adding [FEATURE] to your entry in the changelog while merging.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2012-09-19 14:35:12 +0000
+++ debian/changelog 2012-09-19 16:54:26 +0000
@@ -22,6 +22,8 @@
22 connections. This is necessary for adequate QA testing (LP: #1042425)22 connections. This is necessary for adequate QA testing (LP: #1042425)
23 * scripts/graphics_driver: fixed a bug causing the hybrid check to throw an23 * scripts/graphics_driver: fixed a bug causing the hybrid check to throw an
24 exception on hybrid systems (LP: #1048058)24 exception on hybrid systems (LP: #1048058)
25 * jobs/keys.txt.in: modified the battery info key job to use the keys_test
26 script as we do with other hotkey tests (LP: #990538)
2527
26 [Daniel Manrique]28 [Daniel Manrique]
27 * Bumped to 0.14.6 to keep changelog size sane and fix a small mishap in the29 * Bumped to 0.14.6 to keep changelog size sane and fix a small mishap in the
@@ -114,7 +116,11 @@
114 the 'device' argument (bus type) and require at least one value116 the 'device' argument (bus type) and require at least one value
115 * [FEATURE] scripts/removable_storage_watcher: add support for debugging117 * [FEATURE] scripts/removable_storage_watcher: add support for debugging
116118
119<<<<<<< TREE
117 -- Jeff Lane <jeff@ubuntu.com> Wed, 19 Sep 2012 10:33:17 -0400120 -- Jeff Lane <jeff@ubuntu.com> Wed, 19 Sep 2012 10:33:17 -0400
121=======
122 -- Jeff Lane <jeff@ubuntu.com> Wed, 19 Sep 2012 11:53:49 -0400
123>>>>>>> MERGE-SOURCE
118124
119checkbox (0.14.5) quantal; urgency=low125checkbox (0.14.5) quantal; urgency=low
120126
121127
=== modified file 'jobs/keys.txt.in'
--- jobs/keys.txt.in 2012-05-31 14:45:25 +0000
+++ jobs/keys.txt.in 2012-09-19 16:54:26 +0000
@@ -46,13 +46,17 @@
46plugin: manual46plugin: manual
47name: keys/battery-info47name: keys/battery-info
48requires: dmi.product in ['Notebook','Laptop','Portable']48requires: dmi.product in ['Notebook','Laptop','Portable']
49comand: key_test -s '0xe071,0xef1:Battery Info'
49_description:50_description:
50 PURPOSE:51 PURPOSE:
51 This test will test the battery information key52 This test will test the battery information key
52 STEPS:53 STEPS:
53 1. Press the battery information key on the keyboard54 If you do not have a Battery Button, skip this test
55 1. Click Test to begin
56 2. Press the Battery Info button (or combo like Fn+F3)
57 3: Close the Power Statistics tool if it opens
54 VERIFICATION:58 VERIFICATION:
55 Did a notification appear showing the battery status?59 Did the Battery Info key work as expected?
5660
57plugin: manual61plugin: manual
58name: keys/wireless62name: keys/wireless

Subscribers

People subscribed via source and target branches