Code review comment for lp:~bladernr/checkbox/953160-mmc-not-sdio

TienFu Chen (ctf) wrote :

Looks good,
I ran the command as below, but got the message "Expected device usb inserted" for twice.
-------------------------------------
sudo ./removable_storage_watcher insert usb sdio scsi
Expected device usb inserted
Expected device usb inserted
-------------------------------------
I examined the parameters of function job_change_detected: devices, job_in_progress, job_id, job_num_tasks, job_cur_task_id, job_cur_task_percentage, from the first and second run of job_change_detected. Those parameters are the same. So it implies when the usb is inserted, the usb is being mounted for twice?

---------------------
/org/freedesktop/UDisks/devices/sdb1
1
FilesystemMount
1000
0
-1.0
Expected device usb inserted
/org/freedesktop/UDisks/devices/sdb1
1
FilesystemMount
1000
0
-1.0
---------------------

review: Approve

« Back to merge proposal