Code review comment for lp:~bladernr/checkbox/949435-remove-hard-coded-paths

Javier Collado (javier.collado) wrote :

In `xrandr_cycle`, I don't like much the line in which `my_path` is being assigned because:

- is defined in line 20 and not used until line 87
- the name isn't very descriptive
- I'm not sure why `os.path.split(<whatever>)[0]` is used instead of `os.path.dirname`
  (even if it contains another call to `os.path.dirname`)

The last two comments also apply to `gpu_test`

« Back to merge proposal