Merge lp:~bladernr/checkbox/1611494-virt-pull-correct-image into lp:checkbox

[Jeff Lane ]

Changes virtualization script so that it pulls the correct cloud image for amd64 arch. Rather than pulling i386 images for both i386 and amd64 arch, it now pulls i386 and amd64 cloud images respectively.

[Paul Larson (pwlars)]

Seems reasonable, any idea why it was ever i386?

review: Approve

[Jeff Lane  (bladernr)]

Not really... I think it was simply because i386 works on both archs,
I dont know.

But sometime between now and 18.04, they're supposed to be dropping
i386 support for soem images (not sure right now if that applies to
cloud images as well as ISOs, or no). So this was as much to just
make the test more accurate as it was to future-proof it.

On Wed, Aug 10, 2016 at 3:42 PM, Paul Larson <email address hidden> wrote:
> Review: Approve
>
> Seems reasonable, any idea why it was ever i386?
> --
> https://code.launchpad.net/~bladernr/checkbox/1611494-virt-pull-correct-image/+merge/302571
> You are the owner of lp:~bladernr/checkbox/1611494-virt-pull-correct-image.
>
> Launchpad-Message-Rationale: Owner
> Launchpad-Message-For: bladernr
> Launchpad-Notification-Type: code-review
> Launchpad-Branch: ~bladernr/checkbox/1611494-virt-pull-correct-image
> Launchpad-Project: checkbox

--
"Entropy isn't what it used to be."

Jeff Lane -
Server Certification Lead, Warrior Poet, Biker, Lover of Pie
Phone: [phone]
Ubuntu Ham: W4KDH Freenode IRC: bladernr or bladernr_
gpg: 1024D/3A14B2DD 8C88 B076 0DD7 B404 1417 C466 4ABD 3635 3A14 B2DD

=== modified file 'providers/plainbox-provider-checkbox/bin/virtualization'
--- providers/plainbox-provider-checkbox/bin/virtualization	2016-05-18 19:02:12 +0000
+++ providers/plainbox-provider-checkbox/bin/virtualization	2016-08-10 15:58:44 +0000
@@ -88,7 +88,7 @@
     },
     'amd64': {
         'cloudimg_type': CLOUD_IMAGE_TYPE_DISK,
-        'cloudimg_arch': 'i386',
+        'cloudimg_arch': 'amd64',
         'qemu_bin': 'qemu-system-x86_64',
         'qemu_disk_type': QEMU_DISK_TYPE_VIRTIO,
         'qemu_extra_args': [