Merge lp:~bladernr/checkbox/1188221-fix-sleep-tests into lp:checkbox

Proposed by Jeff Lane 
Status: Merged
Approved by: Daniel Manrique
Approved revision: 2175
Merged at revision: 2173
Proposed branch: lp:~bladernr/checkbox/1188221-fix-sleep-tests
Merge into: lp:checkbox
Diff against target: 48 lines (+6/-3)
3 files modified
checkbox-old/debian/changelog (+3/-0)
checkbox-old/scripts/fwts_test (+1/-1)
checkbox-old/scripts/sleep_test (+2/-2)
To merge this branch: bzr merge lp:~bladernr/checkbox/1188221-fix-sleep-tests
Reviewer Review Type Date Requested Status
Daniel Manrique (community) Approve
Review via email: mp+168730@code.launchpad.net

Description of the change

sleep_test and fwts_test now look for "Resuming tasks ..." rather than the original "PM: Finishing wakeup." message

Also cleaned up sleep_test output to match that of fwts_test so that sleep_time_check doesn't break due to unexpected python log timestamps (that aren't really necessary for the log output anyway)

To post a comment you must log in.
Revision history for this message
Daniel Manrique (roadmr) wrote :

+1, thanks for fixing this!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'checkbox-old/debian/changelog'
--- checkbox-old/debian/changelog 2013-06-07 13:33:16 +0000
+++ checkbox-old/debian/changelog 2013-06-11 16:33:26 +0000
@@ -7,6 +7,9 @@
7 * jobs/stress.txt.in: added dependencies on single cycle tests to the 307 * jobs/stress.txt.in: added dependencies on single cycle tests to the 30
8 cycle S3 and S4 test to avoid unnecessary rebooting by tester on expected8 cycle S3 and S4 test to avoid unnecessary rebooting by tester on expected
9 failures. (LP: #1188284)9 failures. (LP: #1188284)
10 * scripts/fwts_test, scripts/sleep_test: Tests now use a more reliabe marker
11 to determine when the system completed resume. sleep_test output cleaned up
12 to match fwts_test output and not break sleep_time_check (LP: #1188221)
1013
11 [ Brendan Donegan ]14 [ Brendan Donegan ]
12 * jobs/optical.txt.in - Added VERIFICATION section for cdrom-write job so that15 * jobs/optical.txt.in - Added VERIFICATION section for cdrom-write job so that
1316
=== modified file 'checkbox-old/scripts/fwts_test'
--- checkbox-old/scripts/fwts_test 2013-05-29 07:50:30 +0000
+++ checkbox-old/scripts/fwts_test 2013-06-11 16:33:26 +0000
@@ -63,7 +63,7 @@
63 sleep_end_time = re.split('[\[\]]', loglist[idx - 1])[1].strip()63 sleep_end_time = re.split('[\[\]]', loglist[idx - 1])[1].strip()
64 resume_start_time = re.split('[\[\]]', loglist[idx])[1].strip()64 resume_start_time = re.split('[\[\]]', loglist[idx])[1].strip()
65 idx += 165 idx += 1
66 if 'PM: Finishing wakeup.' in loglist[idx]:66 if 'Restarting tasks' in loglist[idx]:
67 resume_end_time = re.split('[\[\]]', loglist[idx])[1].strip()67 resume_end_time = re.split('[\[\]]', loglist[idx])[1].strip()
68 if end_marker in loglist[idx]:68 if end_marker in loglist[idx]:
69 run = 'PASS'69 run = 'PASS'
7070
=== modified file 'checkbox-old/scripts/sleep_test'
--- checkbox-old/scripts/sleep_test 2013-05-29 07:50:30 +0000
+++ checkbox-old/scripts/sleep_test 2013-06-11 16:33:26 +0000
@@ -189,7 +189,7 @@
189 loglist[idx])[1].strip()189 loglist[idx])[1].strip()
190 logging.debug('Resume started at %s' % resume_start_time)190 logging.debug('Resume started at %s' % resume_start_time)
191 idx += 1191 idx += 1
192 if 'PM: Finishing wakeup' in loglist[idx]:192 if 'Restarting tasks' in loglist[idx]:
193 resume_end_time = re.split('[\[\]]',193 resume_end_time = re.split('[\[\]]',
194 loglist[idx])[1].strip()194 loglist[idx])[1].strip()
195 logging.debug('Resume ended at %s' % resume_end_time)195 logging.debug('Resume ended at %s' % resume_end_time)
@@ -322,7 +322,7 @@
322 return 1322 return 1
323323
324 # Set up logging handler324 # Set up logging handler
325 format = '%(asctime)s %(levelname)-8s %(message)s'325 format = '%(message)s'
326 handler = ListDictHandler(sys.stdout)326 handler = ListDictHandler(sys.stdout)
327 handler.setFormatter(logging.Formatter(format))327 handler.setFormatter(logging.Formatter(format))
328 handler.setLevel(logging.INFO)328 handler.setLevel(logging.INFO)

Subscribers

People subscribed via source and target branches