Merge lp:~bladernr/checkbox/1188221-fix-sleep-tests into lp:checkbox

Proposed by Jeff Lane 
Status: Merged
Approved by: Daniel Manrique
Approved revision: 2175
Merged at revision: 2173
Proposed branch: lp:~bladernr/checkbox/1188221-fix-sleep-tests
Merge into: lp:checkbox
Diff against target: 48 lines (+6/-3)
3 files modified
checkbox-old/debian/changelog (+3/-0)
checkbox-old/scripts/fwts_test (+1/-1)
checkbox-old/scripts/sleep_test (+2/-2)
To merge this branch: bzr merge lp:~bladernr/checkbox/1188221-fix-sleep-tests
Reviewer Review Type Date Requested Status
Daniel Manrique (community) Approve
Review via email: mp+168730@code.launchpad.net

Description of the change

sleep_test and fwts_test now look for "Resuming tasks ..." rather than the original "PM: Finishing wakeup." message

Also cleaned up sleep_test output to match that of fwts_test so that sleep_time_check doesn't break due to unexpected python log timestamps (that aren't really necessary for the log output anyway)

To post a comment you must log in.
Revision history for this message
Daniel Manrique (roadmr) wrote :

+1, thanks for fixing this!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'checkbox-old/debian/changelog'
2--- checkbox-old/debian/changelog 2013-06-07 13:33:16 +0000
3+++ checkbox-old/debian/changelog 2013-06-11 16:33:26 +0000
4@@ -7,6 +7,9 @@
5 * jobs/stress.txt.in: added dependencies on single cycle tests to the 30
6 cycle S3 and S4 test to avoid unnecessary rebooting by tester on expected
7 failures. (LP: #1188284)
8+ * scripts/fwts_test, scripts/sleep_test: Tests now use a more reliabe marker
9+ to determine when the system completed resume. sleep_test output cleaned up
10+ to match fwts_test output and not break sleep_time_check (LP: #1188221)
11
12 [ Brendan Donegan ]
13 * jobs/optical.txt.in - Added VERIFICATION section for cdrom-write job so that
14
15=== modified file 'checkbox-old/scripts/fwts_test'
16--- checkbox-old/scripts/fwts_test 2013-05-29 07:50:30 +0000
17+++ checkbox-old/scripts/fwts_test 2013-06-11 16:33:26 +0000
18@@ -63,7 +63,7 @@
19 sleep_end_time = re.split('[\[\]]', loglist[idx - 1])[1].strip()
20 resume_start_time = re.split('[\[\]]', loglist[idx])[1].strip()
21 idx += 1
22- if 'PM: Finishing wakeup.' in loglist[idx]:
23+ if 'Restarting tasks' in loglist[idx]:
24 resume_end_time = re.split('[\[\]]', loglist[idx])[1].strip()
25 if end_marker in loglist[idx]:
26 run = 'PASS'
27
28=== modified file 'checkbox-old/scripts/sleep_test'
29--- checkbox-old/scripts/sleep_test 2013-05-29 07:50:30 +0000
30+++ checkbox-old/scripts/sleep_test 2013-06-11 16:33:26 +0000
31@@ -189,7 +189,7 @@
32 loglist[idx])[1].strip()
33 logging.debug('Resume started at %s' % resume_start_time)
34 idx += 1
35- if 'PM: Finishing wakeup' in loglist[idx]:
36+ if 'Restarting tasks' in loglist[idx]:
37 resume_end_time = re.split('[\[\]]',
38 loglist[idx])[1].strip()
39 logging.debug('Resume ended at %s' % resume_end_time)
40@@ -322,7 +322,7 @@
41 return 1
42
43 # Set up logging handler
44- format = '%(asctime)s %(levelname)-8s %(message)s'
45+ format = '%(message)s'
46 handler = ListDictHandler(sys.stdout)
47 handler.setFormatter(logging.Formatter(format))
48 handler.setLevel(logging.INFO)

Subscribers

People subscribed via source and target branches