Merge lp:~bladernr/checkbox/1128017-improve-network_check into lp:checkbox
Proposed by
Jeff Lane
Status: | Merged |
---|---|
Approved by: | Zygmunt Krynicki |
Approved revision: | 2102 |
Merged at revision: | 2102 |
Proposed branch: | lp:~bladernr/checkbox/1128017-improve-network_check |
Merge into: | lp:checkbox |
Diff against target: |
36 lines (+7/-1) 2 files modified
debian/changelog (+2/-0) scripts/network_check (+5/-1) |
To merge this branch: | bzr merge lp:~bladernr/checkbox/1128017-improve-network_check |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Zygmunt Krynicki (community) | Approve | ||
Review via email: mp+162240@code.launchpad.net |
Description of the change
Improves network_check by adding the ability to test against a URL other than cdimage.ubuntu.com. This is useful when the test simply fails and needs a bit of debug to validate that the issue is not simply that cdimage.ubuntu.com is not accessible by the user for some reason.
To post a comment you must log in.
24 + help='The target URL to try. Default is %(default)s')
default is not interpolated unless you do some bit of argparse magic (grep for default in plainbox to see)
Otherwise ok