lsmod_info crashed with subprocess.CalledProcessError in check_output(): Command '['/sbin/modinfo', 'nvidia']' returned non-zero exit status 1

Bug #1103647 reported by gurqn
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Checkbox
Fix Released
Undecided
Unassigned
checkbox (Ubuntu)
Fix Released
Medium
Jeff Lane 

Bug Description

When run system test app

ProblemType: Crash
DistroRelease: Ubuntu 13.04
Package: checkbox 0.15
ProcVersionSignature: Ubuntu 3.8.0-1.5-generic 3.8.0-rc4
Uname: Linux 3.8.0-1-generic x86_64
NonfreeKernelModules: nvidia
ApportVersion: 2.8-0ubuntu2
Architecture: amd64
Date: Wed Jan 23 21:23:34 2013
ExecutablePath: /usr/lib/checkbox/bin/lsmod_info
InstallationDate: Installed on 2013-01-23 (0 days ago)
InstallationMedia: Ubuntu 13.04 "Raring Ringtail" - Alpha amd64 (20130122)
InterpreterPath: /usr/bin/python3.3
MarkForUpload: True
ProcCmdline: /usr/bin/python3 /usr/share/checkbox/scripts/lsmod_info
ProcEnviron:
 SHELL=/bin/bash
 PATH=(custom, no user)
 LANG=en_US.UTF-8
 PYTHONPATH=:/usr/share/checkbox
 XDG_RUNTIME_DIR=<set>
PythonArgs: ['/usr/share/checkbox/scripts/lsmod_info']
SourcePackage: checkbox
Title: lsmod_info crashed with subprocess.CalledProcessError in check_output(): Command '['/sbin/modinfo', 'nvidia']' returned non-zero exit status 1
UpgradeStatus: No upgrade log present (probably fresh install)
UserGroups: adm cdrom dip lpadmin plugdev sambashare sudo

Related branches

Revision history for this message
gurqn (gurqn-home) wrote :
tags: removed: need-duplicate-check
Changed in checkbox (Ubuntu):
importance: Undecided → Medium
Revision history for this message
Jeff Lane  (bladernr) wrote :

This happens because the nVidia proprietary driver appears as a kernel module, but modinfo fails because nothing is returned:

bladernr@klaatu:$ lsmod |grep nvidia
nvidia 9410995 52
bladernr@klaatu:$ modinfo nvidia
ERROR: Module nvidia not found.

information type: Private → Public
Changed in checkbox (Ubuntu):
assignee: nobody → Jeff Lane (bladernr)
status: New → Confirmed
status: Confirmed → Triaged
Revision history for this message
Jeff Lane  (bladernr) wrote :

check_output() raises a CalledProcessError if cmd returns anything but 0. Not sure why we're trapping OSError instead, I can't find anything that indicates check_output() will ever raise OSError.

Simple enough to change the error handling. We'll trap CalledProcessError. If it's anything but a 1, there's likely something else going on, so we want to raise that. But a 1 is usually indicative of "Module $FOO not found" as shown above. So for those, we'll just pass 'Unavailable' back.

Changed in checkbox (Ubuntu):
status: Triaged → In Progress
Jeff Lane  (bladernr)
Changed in checkbox (Ubuntu):
status: In Progress → Fix Committed
Jeff Lane  (bladernr)
Changed in checkbox:
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (7.8 KiB)

This bug was fixed in the package checkbox - 0.16

---------------
checkbox (0.16) saucy; urgency=low

  * New upstream release (LP: #1178403):

  * Launchpad automated translation updates

  [ Jeff Lane ]
  * scripts/cpu_offlining: Modified script to no longer offline cpu0 to resolve
    a bug on ARM. Modified output so most of it is redirected to stderr for
    fail cases, we don't need that much for success cases. (LP: #1078897)
  * jobs/mediacard.txt.in: Modified test instructions to be less confusing
    (LP: #970857)
  * scripts/cpu_topology: define the cpuinfo nested dicts on creation rather
    than define elements during parsing of /proc/cpuinfo (LP: #1111878)
  * scripts/lsmod_info: Corrected error handling for the check_output() call to
    trap the correct error. (LP: #1103647)
  * jobs/camera.txt.in: removed an extraneous requres line for gir1.2
    scripts/camera_test: added code to determine what version of gst we're
    using and set video type and plugin accordingly. (LP: #1100594)
  * scripts/network_check: added ability to specify custom target URL for
    debugging failures (LP: #1128017)
  * scripts/sleep_test_log_check: added new script to parse fwts logs for
    errors
    jobs/hibernate.txt.in, jobs/stress.txt.in, jobs/suspend.txt.in: added jobs
    to use the sleep_test_log_check script after s3/s4 tests. Modified current
    s3/s4 tests to use the new None fail level for fwts_test
    scripts/fwts_test: no longer fails on fwts errors if "-f none" is chosen.
    Now it should only fail by manual indication if the actual sleep action
    fails. (LP: #1169922)
  * scripts/bluetooth_test: test no longer generates odd Broken Pipe error when
    the dpkg bit verifies obexftp is installed (LP: #1169488)
  * jobs/networking.txt.in: fixed networking/info jobs that were not being run
    because $output was being resolved too early (LP: #1065983)
  * scripts/memory_compare: cleaned up the output to be more explanatory and
    easier to visually parse (LP: #1072666)
  * jobs/miscellanea.txt.in: Added jobs for manual verification of PXE boot and
    remote IPMI to improve server test coverage.
  * jobs/led.txt.in: Modified Jobs: led/power, led/wlan, led/wlan-disabled. New
    jobs: led/power-blink-suspend, led/suspend, led/mute
    jobs/keys.txt.in: modified keys/wireless
  * plugins/lock_prompt.py: added a lock release to cleanly clear lock on stop.
    plugins/persist_prompt.py: promoted save to run before lock release.
    checkbox/lib/fifo.py: trap OSError exception at close when the input/output
    fifo fds disappear before fifo.close() can get to them. (LP: #115561)
  * jobs/info.txt.in: fixed bad driver name in audio_codecs job (LP: #1165215)
  * jobs/mediacard.txt.in: reduce test file size for MMC to 64MB (LP: #1167214)
  * jobs/led.txt.in, jobs/suspend.txt.in: removed bits about WLAN LED flashing
    from the WLAN jobs as that no longer happens on data tx/rx (LP: #1157606)
  * jobs/power-management.txt.in: added manual reboot and shutdown tests for
    server and Xen testing. Took the opportunity to correct punctuation in the
    descriptions or other manual jobs.
    jobs/virtualization.txt.in: added virtualization/x...

Read more...

Changed in checkbox (Ubuntu):
status: Fix Committed → Fix Released
Changed in checkbox:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.