Code review comment for lp:~bladernr/checkbox/1100594-fix-camera_test-new-gir1.2

Brendan: fixed my two pep8 errors (spaces) the rest are original to sylvain's code. I've fixed all of those but one because no matter what I tried, I couldn't keep it from generating several more pep8 problems that were seemingly unsolvable. But this one remaining one has been in the test for a long while now so it shouldn't affect things, I hope.

As for fswebcam, it's not specifically the lack of fswebcam, that just brought it to the attention of the guy who reported the bug initially. IIRC, you mentioned the "display" test, which uses gstreamer to create the display window, so I'd expect you would see that bug there.

If this updated script doesn't resolve it on your end, there may be more going on than simply setting the right plugin and video type for gstreamer.

Zygmunt: Yeah, probably so, there are 17 scripts that rely on python3-gi, none of which list it as a requirement. I'm not going to fix those here. That said, however, python3-gi is required for installing checkbox itself, rathter than just a suggests. Then again, so are the gir1.2 packages, so really, neither of those should be required on a test by test basis, you'd think, since they're already required for installing checkbox to begin with.

Anyway, here's a new version with fixes to some problems I didn't catch the first time, and a rash of PEP8 fixes as well.