Merge lp:~bladernr/checkbox/1053032 into lp:checkbox

Proposed by Jeff Lane 
Status: Merged
Merged at revision: 1683
Proposed branch: lp:~bladernr/checkbox/1053032
Merge into: lp:checkbox
Diff against target: 79 lines (+18/-20) (has conflicts)
2 files modified
debian/changelog (+10/-0)
jobs/usb.txt.in (+8/-20)
Text conflict in debian/changelog
To merge this branch: bzr merge lp:~bladernr/checkbox/1053032
Reviewer Review Type Date Requested Status
Marc Tardif (community) Approve
Jeff Lane  Needs Resubmitting
Review via email: mp+125300@code.launchpad.net

Description of the change

Like the bluetooth changes, combined usb/mouse and usb/keyboard into a single test so the user only needs one device rather than two for testing

To post a comment you must log in.
Revision history for this message
Marc Tardif (cr3) wrote :

string changes should be accompanied with [FEATURE] in the changelog.

review: Needs Fixing
lp:~bladernr/checkbox/1053032 updated
1676. By Jeff Lane 

changelog cleanup

Revision history for this message
Jeff Lane  (bladernr) wrote :

fixed

review: Needs Resubmitting
Revision history for this message
Marc Tardif (cr3) wrote :

Okie dokie.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2012-09-19 19:05:43 +0000
+++ debian/changelog 2012-09-19 20:12:20 +0000
@@ -22,6 +22,7 @@
22 connections. This is necessary for adequate QA testing (LP: #1042425)22 connections. This is necessary for adequate QA testing (LP: #1042425)
23 * scripts/graphics_driver: fixed a bug causing the hybrid check to throw an23 * scripts/graphics_driver: fixed a bug causing the hybrid check to throw an
24 exception on hybrid systems (LP: #1048058)24 exception on hybrid systems (LP: #1048058)
25<<<<<<< TREE
25 * setup.py: added checkbox.dbus to packages (LP: #1052601)26 * setup.py: added checkbox.dbus to packages (LP: #1052601)
26 * jobs/optical.txt.in: removed the optical/dvd_movie_playback job definition27 * jobs/optical.txt.in: removed the optical/dvd_movie_playback job definition
27 as it was redundant (LP: #868643)28 as it was redundant (LP: #868643)
@@ -30,6 +31,11 @@
30 * [FEATURE] jobs/bluetooth.txt.in: removed the bluetooth/keyboard job31 * [FEATURE] jobs/bluetooth.txt.in: removed the bluetooth/keyboard job
31 and modified bluetooth/mouse to be bluetooth/HID and allow the tester32 and modified bluetooth/mouse to be bluetooth/HID and allow the tester
32 to choose a device to use. (LP: #1053010)33 to choose a device to use. (LP: #1053010)
34=======
35 * [FEATURE] jobs/usb.txt.in: replaced the usb/mouse and usb/keyboard tests
36 with usb/HID to combine them so the tester can choose one device rather
37 than requiring multiple devices. (LP: #1053032)
38>>>>>>> MERGE-SOURCE
3339
34 [Daniel Manrique]40 [Daniel Manrique]
35 * Bumped to 0.14.6 to keep changelog size sane and fix a small mishap in the41 * Bumped to 0.14.6 to keep changelog size sane and fix a small mishap in the
@@ -122,7 +128,11 @@
122 the 'device' argument (bus type) and require at least one value128 the 'device' argument (bus type) and require at least one value
123 * [FEATURE] scripts/removable_storage_watcher: add support for debugging129 * [FEATURE] scripts/removable_storage_watcher: add support for debugging
124130
131<<<<<<< TREE
125 -- Jeff Lane <jeff@ubuntu.com> Wed, 19 Sep 2012 13:09:08 -0400132 -- Jeff Lane <jeff@ubuntu.com> Wed, 19 Sep 2012 13:09:08 -0400
133=======
134 -- Jeff Lane <jeff@ubuntu.com> Wed, 19 Sep 2012 14:20:15 -0400
135>>>>>>> MERGE-SOURCE
126136
127checkbox (0.14.5) quantal; urgency=low137checkbox (0.14.5) quantal; urgency=low
128138
129139
=== modified file 'jobs/usb.txt.in'
--- jobs/usb.txt.in 2012-08-22 18:51:58 +0000
+++ jobs/usb.txt.in 2012-09-19 20:12:20 +0000
@@ -23,31 +23,19 @@
23 Were the drives detected?23 Were the drives detected?
2424
25plugin: manual25plugin: manual
26name: usb/keyboard26name: usb/HID
27depends: usb/detect27depends: usb/detect
28requires: package.name == 'linux'28requires: package.name == 'linux'
29command: keyboard_test29command: keyboard_test
30_description:30_description:
31 PURPOSE:31 PURPOSE:
32 This test will check your USB connection.32 This test will check that you can use a USB HID device
33 STEPS:33 STEPS:
34 1. Plug a USB keyboard into the computer.34 1. Enable either a USB mouse or keyboard
35 2. Click on "Test" and enter some text.35 2. For mice, perform actions such as moving the pointer, right and left button clicks and double clicks
36 VERIFICATION:36 3. For keyboards, click the Test button to lauch a small tool. Type some text and close the tool.
37 Does the keyboard work?37 VERIFICATION:
3838 Did the device work as expected?
39plugin: manual
40name: usb/mouse
41depends: usb/detect
42requires: package.name == 'linux'
43_description:
44 PURPOSE:
45 This test will check your USB connection.
46 STEPS:
47 1. Plug a USB mouse into the computer.
48 2. Perform some single/double/right click operations.
49 VERIFICATION:
50 Does the mouse work correctly?
5139
52plugin: manual40plugin: manual
53name: usb/insert41name: usb/insert

Subscribers

People subscribed via source and target branches