Code review comment for lp:~bkerensa/ubuntu/precise/xfce4-weather-plugin/fix-typo-strings

Revision history for this message
Benjamin Kerensa (bkerensa) wrote :

The differences in the merge proposal and the patch I sent upstream is due to the fact that likely Debian fixed the strings in panel-plugin/weather-data.c because they simply do not exist in our local source package but they do exist upstream of Debian with the XFCE project. I reviewed the changelog and could not see any indication that the string in panel-plugin/weather-data.c was fixed but it clearly is not present.

It is possible to just wait for XFCE to apply my patch and for it to trickle down to Debian -> Ubuntu
I am unsure how long that process generally takes but notably other patches I have submitted to projects Upstream of Debian that are already applied have yet to even hit Debian let alone Ubuntu.

So perhaps months? The question is do we want to carry my fix in Ubuntu?

« Back to merge proposal