Code review comment for lp:~bkerensa/charms/precise/subway/trunk

Revision history for this message
Charles Butler (lazypower) wrote :

Benjamin,

Thank you so much for the contribution. I've taken the liberty of reviewing your change, and it appears that the merge has broken functionality. The PPA provided by chris-lea still functions and communicates with NPM. When I merged your changes that remove the PPA, and reverts to the ubuntu archives, communication with the npm distribution server was not functional.

Until such a time arrives that the npm package in teh ubuntu archive is able to communicate with the npmjs server, i cannot approve this merge.

Thanks again for the submission. I'm going to change status of this MP to "needs work" and when you're ready for another review please click the "Request another review" button in the upper right hand corner of the commit message.

If you have any questions/comments/concerns about the review contact us in #juju on irc.freenode.net or email the mailing list <email address hidden>, or ask a question tagged with "juju" on http://askubuntu.com.

review: Needs Fixing

« Back to merge proposal