Code review comment for lp:~bkerensa/charms/precise/subway/trunk

Revision history for this message
Kapil Thangavelu (hazmat) wrote :

lgtm

On Mon, Jul 16, 2012 at 1:03 PM, Benjamin Kerensa <email address hidden>wrote:

> Benjamin Kerensa has proposed merging
> lp:~bkerensa/charms/precise/subway/trunk into lp:charms/subway.
>
> Requested reviews:
> Mark Mims (mark-mims)
>
> For more details, see:
>
> https://code.launchpad.net/~bkerensa/charms/precise/subway/trunk/+merge/115188
>
> * Replaced PPA with install of nodejs from Ubuntu Archives
>
> --
>
> https://code.launchpad.net/~bkerensa/charms/precise/subway/trunk/+merge/115188
> Your team charmers is subscribed to branch lp:charms/subway.
>
> === modified file 'hooks/install'
> --- hooks/install 2012-03-23 20:29:39 +0000
> +++ hooks/install 2012-07-16 17:02:19 +0000
> @@ -16,9 +16,9 @@
> juju-log "Installing MongoDB"
> sudo apt-get -y install mongodb
>
> -# Grabbing Nodejs from PPA since Ubuntu Repo is outdated
> +# Installing nodejs
> juju-log "Installing nodejs"
> -sudo add-apt-repository -y ppa:chris-lea/node.js && sudo apt-get update
> -y && sudo apt-get -y install nodejs
> +sudo apt-get -y install nodejs
>
> # Install npm and build-essentials
> juju-log "Installing npm"
>
>
>

« Back to merge proposal