~bjornt/maas:perf-test-no-custom-runner

Branch merges

Propose for merging

Merged into maas:master

Alberto Donato (community): Approve on 2022-11-23

MAAS Lander: Approve on 2022-11-23

Diff: 342 lines (+38/-108)

11 files modified

Makefile (+4/-5)
setup.cfg (+0/-1)
src/maasperf/tests/cli/test_machines.py (+0/-4)
src/maasperf/tests/conftest.py (+3/-0)
src/maasperf/tests/maasserver/api/test_machines.py (+0/-16)
src/maasperf/tests/maasserver/models/test_machine.py (+0/-12)
src/maasperf/tests/maasserver/websockets/test_machines.py (+0/-11)
src/maastesting/perftest.py (+0/-48)
src/maastesting/pytest.py (+30/-0)
src/maastesting/scripts.py (+0/-10)
utilities/run-perf-tests-ci (+1/-1)

api

Superseded for merging into maas:master

MAAS Maintainers: Pending requested 2022-11-23

Diff: 442 lines (+131/-87)

10 files modified

Makefile (+8/-5)
setup.cfg (+0/-1)
src/maasperf/tests/cli/test_machines.py (+12/-11)
src/maasperf/tests/conftest.py (+13/-0)
src/maasperf/tests/maasserver/api/test_machines.py (+9/-7)
src/maasperf/tests/maasserver/models/test_machine.py (+7/-6)
src/maasperf/tests/maasserver/websockets/test_machines.py (+5/-5)
src/maastesting/perftest.py (+46/-51)
src/maastesting/pytest.py (+30/-0)
utilities/run-perf-tests-ci (+1/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

0c79681... by Björn Tillenius on 2022-11-24

Drop default scope

a5b7e76... by Björn Tillenius on 2022-11-24

Drop bin/test.perf

8df31f8... by Björn Tillenius on 2022-11-23

Remove the custom bin/test.perf runner.

There's no reason to have a custom test runner. It's better to
use pytest directly, so that it's clear how to use it.

I also improved the way we set the random seed, so that we do
it per-test and not per-session, and print out the used values
on test failures.

I kept bin/test.perf as a symlink, in case someone is very
used to it.

d4502c5... by Peter Makowski on 2022-11-24

Update maas-ui to 5808e4117
log generic websocket errors to the console (#4584)

88921c7... by Björn Tillenius on 2022-11-24

Remove the @perf_test decorator.

It's not needed, and it was somewhat broken. It reverted back to
a savepoint, unless commit_transaction was true. In that case
it simply removed the savepoint. I'm not quite sure what the intent
was there. If it was to simulate a commit, it was in the wrong
place, since it was outside the block that measures the duration.

The transaction is rolled back elsewhere for each tests, so no
need for a custom decorator. The decorator also had logic for
skipping the tests if django wasn't loaded, but I don'

5003b42... by Björn Tillenius on 2022-11-24

Make it more explicit what to measure in the performance tests

Before, we measured how long the whole test took to run. That includes
any local setup you do in the test, but also the setup of any fixtures
the test uses.

I also combined measuring the time and, optionally, do profiling
using cProfile. It's more logical that you want to profile the
thing that you are actually measuring.

30a43bf... by Anton Troyanov on 2022-11-23

fix(vault): vmhost should use get_power_parameters

02524b2... by Alberto Donato on 2022-11-23

disable request retries for controller script results reporting to region

The logic used for the refresh is the same used by scrips reporting for
machines, but there's no need to retry for controllers refresh, since the
service runs every 30s anyway

963f588... by Peter Makowski on 2022-11-23

Update maas-ui to 44625e63e
integrate suppress_failed_script_results action (#4578)

4941c41... by Nick De Villiers on 2022-11-23

Update maas-ui to 2681e0951
fix(vault): show icon in controller listing if all controllers are configured but secrets are not migrated (#4579)