Code review comment for lp:~bjornt/lp2kanban/bugs-to-cards

Revision history for this message
Benji York (benji) wrote :

The branch looks good. I didn't see anything that should prevent this
from landing but I had several comments/suggestions while reading the
code.

> I'm not completely happy with 3), since it adds noise to the bug and
> requires authenticated use of the API, but it's needed, since
> otherwise the list of bugs to process would just grow and grow.

An idea how to tag cards as synced with kanban without having to remove
the tags later: Tag bugs that should be synced, the script then queries
for non-closed, tagged bugs and compares against existing cards,
creating those that do not yet exist.

We will be processing a few more bugs than is strictly necessary, but
once a bug is closed it will fall out of the set of bugs being
inspected, so the number of bugs examined will be bounded.

This approach also means that "semantic" tags can be used to manage
cards. For example, if you have a project to implement the "gizmo"
feature and all the "gizmo" bugs are already tagged, you can just start
running lp2kanban with the new tag name and all the bugs will have cards
created and the tags won't be removed (as they would now).

What do you think about that?

Config option brainstorming
---------------------------

bug_new_card_tag:

- card_creation_bug_tag
- new_card_bug_tag
- bug_to_card_tag

bug_new_card_type:

- bug_to_card_type

I like the last two suggestions in each category because they share a
prefix and "bug_to_card" is relatively obvious in meaning.

Is my reading correct in that create_new_cards creates all the bugs in
the left-most lane? It would be nice for that to be configurable, many
boards aren't structured that way. In fact, I can see people running
multiple passes; creating cards from one tag in one lane and cards from
another tag in another.

Hmm, maybe that doesn't matter because the cards are then synced after
they are created, thus moving them into the correct lanes. If that is
correct, then a comment to that effect in create_new_cards would be
helpful.

Shouldn't the newly created cards have the "Synced with Launchpad"
marker added to the description? Wait, since the cards are "dirty",
that will be done by save_board, right?

The tests are appreciated.

We could use some tests for create_new_cards too. I would include tests
for the lane lookup code (possibly breaking it out into its own
function) and for the card type name to card type ID translation
function (it would probably benefit from being its own function too).

review: Approve (code)

« Back to merge proposal