Code review comment for lp:~bjornt/launchpad/windmill-test-layer

Revision history for this message
Björn Tillenius (bjornt) wrote :

Make it possible to run Windmill tests using our normal test runner.

This branch adds test layers for Windmill tests, so ideally you could be
able to run all Windmill tests using: bin/test --layer=WindmillLayer.
This doesn't quite work yet. Windmill isn't torned down properly, so you
can only run the tests for one domain at a time:

    bin/test --layer=BugsWindmillLayer

Note the hack in test.in. This is because of bug #429375, which need to
get fixed before landing this branch.

All the old tests need to be converted to use a TestCase. I'm intending
to do that in a separate branch, in order to keep down the diff size.
I've converted one Bugs and one Code test as a proof-of-concept.

The reason for integrating the Windmill test into our test suite is to
make it easier to run the tests. I always forget how to run the tests
using bin/lp-windmill and bin/windmill. Using bin/test also means that
it's easier to see which tests pass and fail.

As a bonus, it's now possible to use LaunchpadObjectFactory in our
Windmill tests to do setup. In the future, I'd also like to reset the db
between tests.

--
Björn Tillenius | https://launchpad.net/~bjornt

« Back to merge proposal