Code review comment for lp:~bjornt/launchpad/windmill-problems

This branch fixes a bunch of problems with the Windmill tests. Normally
I would have done each fix in a separate branch, but it was hard to see
any progress when applying only a single fix, so I combined them into
one branch. This branch reduces the number of failures from 7-8, to 1-2.
At least one of the remaining test failure looks valid, the other one
intermittent, so I'm going to look into that in another branch.

What I've done is to:

    1) Increase the default timeout values. This should be OK, since the
       only bad effect this has is that tests take longer to fail, if
       they fail when waiting for something. It's too bad, and I'm going
       to look into why everything is taking so long.

    2) Make LaunchpadUser.ensure_login() be able to log in when the
       current page already is a +login page. There were some tests that
       failed, since the previous tests ended on a +login page. In this
       case, ensure_login() though that we were logged in, so it tried
       to press the nonexisting logout button.

    3) Disable the check for left-over threads. This check is meant to
       prevent production code from leaking threads. The only threads
       that are left here are threads that Windmill uses. Since the
       Windmill state is shared across multiple tests, we shouldn't have
       a check between the tests. The threads should be cleaned up when
       the layer is torn down, not when the test is it.

    4) Change test_bug_tags_entry.py to use constants instead of
       hard-coding the timeout values. I did this, because I needed to
       increase the timeouts due to test failures, so it made sense to
       clean it up, instead of increasing the hard-coded timeouts.

--
Björn Tillenius | https://launchpad.net/~bjornt