Code review comment for lp:~bjornt/launchpad/bug-415337

On Wed, Aug 19, 2009 at 10:22:30AM -0000, Gavin Panella wrote:
> Review: Approve
> This looks good.
>
> It's not your fault, but I got a DeprecationWarning when running the
> test:
>
> > lib/canonical/database/harness.py:1: DeprecationWarning: Non-ASCII
> > character '\xc3' in file
> > lib/canonical/launchpad/windmill/testing/lpuser.py on line 71, but
> > no encoding declared; see http://www.python.org/peps/pep-0263.html
> > for details
>
> I think it's because the encoding declaration has been pushed down to
> the fourth line by the new copyright notice. Could you move the
> encoding declaration to the top or change line 71 to use an escape
> sequence instead?

I removed the encoding declaration and changed line 71 to use escape
sequences instead. Having files encoded in a non-ascii encoding is
usually a bad idea.

--
Björn Tillenius | https://launchpad.net/~bjornt