Code review comment for lp:~bjornt/launchpad/bug-415336

Revision history for this message
Björn Tillenius (bjornt) wrote :

Make test_duplicate_finder windmill test pass. The way the collapsible
are shown and hidden had changed, so that the display style property
isn't set to hidden anymore. Instead I check the height of the div. It's
a bit troublesome checking whether the div is hidden, since the height
depends on the font being used, so I did it using javascript to ensure
it's not 0px.

I also changed the start URL to be on the bugs domain, since that caused
a strange failure, probably due to cross-domain posting. This seemed to
be a windmill problem, in a real instance it's ok to start on a non-bugs
domain.

--
Björn Tillenius | https://launchpad.net/~bjornt

« Back to merge proposal