Code review comment for lp:~bjornt/launchpad/bug-376990
Revision history for this message
| Björn Tillenius (bjornt) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
a60fb26
(Get the code!)
On Tue, Jul 28, 2009 at 01:13:29PM -0000, Brad Crittenden wrote:
> Review: Approve mentor
> * line 11: s/want/wants
> * line 13: typo: therefore
Why do I always make that typo? :)
> * The last sentence reads better as:
> Therefore, if no request is explicitly given canonical_url() returns the browser
> URL, even if the current request is a web service request.
Thanks, I'll fix it.
>
> Thanks for making the change to FunctionalLayer. Did you measure the
> improvement?
Yes. It's still quite slow, but took it down from 40 seconds to 20
seconds.
--
Björn Tillenius | https:/