Code review comment for lp:~bjornt/landscape-client/gir-test-failures

The changes look good, but I get a problem on my machine.

trunk:

===============================================================================
[SKIPPED]
imagestore module not available

landscape.manager.tests.test_eucalyptus.EucalyptusTest.test_failed_run_stops_service_hub
landscape.manager.tests.test_eucalyptus.EucalyptusTest.test_run_with_failure_message
landscape.manager.tests.test_eucalyptus.EucalyptusTest.test_run_with_successful_message
landscape.manager.tests.test_eucalyptus.EucalyptusTest.test_successful_run_stops_service_hub
landscape.manager.tests.test_eucalyptus.GetEucalyptusInfoTest.test_wb_get_eucalyptus_info
landscape.manager.tests.test_eucalyptus.StartServiceHubTest.test_start_service_hub
landscape.manager.tests.test_eucalyptus.StartServiceHubTest.test_start_service_hub_with_existing_data_dir
-------------------------------------------------------------------------------
Ran 2245 tests in 147.100s

PASSED (skips=7, successes=2238)

And your branch:

===============================================================================
[ERROR]
Traceback (most recent call last):
  File "/home/jseutter/src/landscape-client/gir-test-failures/landscape/ui/model/registration/tests/test_mechanism.py", line 19, in setUp
    self.bus_name = dbus.service.BusName(INTERFACE_NAME, MechanismTest.bus)
exceptions.AttributeError: type object 'MechanismTest' has no attribute 'bus'

landscape.ui.model.registration.tests.test_mechanism.MechanismTest.test_disabling_fail
landscape.ui.model.registration.tests.test_mechanism.MechanismTest.test_disabling_succeed
landscape.ui.model.registration.tests.test_mechanism.MechanismTest.test_exit
landscape.ui.model.registration.tests.test_mechanism.MechanismTest.test_registration_fail
landscape.ui.model.registration.tests.test_mechanism.MechanismTest.test_registration_succeed
===============================================================================
[ERROR]
Traceback (most recent call last):
  File "/home/jseutter/src/landscape-client/gir-test-failures/landscape/ui/model/registration/tests/test_proxy.py", line 81, in setUp
    RegistrationProxyTest.bus)
exceptions.AttributeError: type object 'RegistrationProxyTest' has no attribute 'bus'

landscape.ui.model.registration.tests.test_proxy.RegistrationProxyTest.test_disable
landscape.ui.model.registration.tests.test_proxy.RegistrationProxyTest.test_exit
landscape.ui.model.registration.tests.test_proxy.RegistrationProxyTest.test_register
-------------------------------------------------------------------------------
Ran 2244 tests in 145.865s

FAILED (skips=7, errors=29, successes=2208)

I haven't looked into the problem any deeper.