Code review comment for lp:~bjornt/landscape-client/apt-facade-changer-optional

Revision history for this message
Björn Tillenius (bjornt) wrote :

On Tue, Nov 15, 2011 at 01:05:26PM -0000, Thomas Herve wrote:
> Review: Approve
>
> [1] You may want to use EnvironSaverHelper to make your os.environ
> changes safer.

Didn't know about EnvironSaverHelper, thanks for pointing it out. I've
change the code to use it, instead of restoring the environment manually.

--
Björn Tillenius | https://launchpad.net/~bjornt

« Back to merge proposal